-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selectable audio input device #3079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compulim
requested review from
a-b-r-o-w-n,
corinagum,
cwhitten,
srinaath,
tdurnford and
tonyanziano
as code owners
April 5, 2020 17:54
compulim
changed the title
[DRAFT] Selectable audio input device
Selectable audio input device
Apr 5, 2020
compulim
force-pushed
the
fix-2481-bluetooth
branch
from
April 5, 2020 17:58
ad620e4
to
530c1f3
Compare
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
samples/03.speech/h.select-audio-input-device/comprehensive.html
Outdated
Show resolved
Hide resolved
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
samples/03.speech/h.select-audio-input-device/comprehensive.html
Outdated
Show resolved
Hide resolved
corinagum
reviewed
Apr 6, 2020
samples/03.speech/h.select-audio-input-device/comprehensive.html
Outdated
Show resolved
Hide resolved
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
samples/03.speech/h.select-audio-input-device/comprehensive.html
Outdated
Show resolved
Hide resolved
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
samples/03.speech/h.select-audio-input-device/comprehensive.html
Outdated
Show resolved
Hide resolved
corinagum
reviewed
Apr 6, 2020
corinagum
reviewed
Apr 6, 2020
corinagum
suggested changes
Apr 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To discuss:
- number of packages published for this project that aren't peer reviewed
- how complicated our single-page samples have gotten. They need to be simpler and split into re-used modules
Tests for Direct Line Speech added. Test is currently failing due to reliability, will fix it. |
corinagum
reviewed
Apr 9, 2020
corinagum
reviewed
Apr 9, 2020
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
Co-Authored-By: Corina <14900841+corinagum@users.noreply.github.com>
compulim
force-pushed
the
fix-2481-bluetooth
branch
from
April 22, 2020 19:05
b21d54b
to
5288298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Entry
Added
Fixed
Changed
microsoft-cognitiveservices-speech-sdk
to reduce footprint, by @compulim in PR #3079Samples
Description
Support selectable audio input device. From user report, even AirPod is connected, on iOS, it is not selected as default. JavaScript is required to select the device and make it default.
Also, today, we have 3 references of
microsoft-cognitiveservices-speech-sdk
, which take up significantly amount of size in our bundle (~300 KB each). We are going to converge them into a single copy inside the bundle.We will temporarily bump to a preview build of
web-speech-cognitive-services
. When we do production release, we will build a production version ofweb-speech-cognitive-services
and bump the version in Web Chat.Specific Changes
webpack.config.js
to reference to the samemicrosoft-cognitiveservices-speech-sdk
package to reduce footprint by ~600 KBaudioContext
option tocreateCognitiveServicesSpeechServicesPonyfillFactory()
audioContext
objectaudioInputDeviceId
option tocreateCognitiveServicesSpeechServicesPonyfillFactory()
audioConfig
is set, we will useaudioInputDeviceId
to select the correct audio input devicepostinstall
script to transpile them afternpm run bootstrap
orlerna add
. We prefer to usepostinstall
because build time is substantial and to reduce the tax on our build@babel/plugin-proposal-async-generation-functions
event-iterator
microsoft-cognitiveservices-speech-sdk
react-say
to not breaking IE11External changes